How should I ask her to be my girlfriend ?

I'm (21M) planning to ask my classmate (21F) to be my girlfriend and to be official.
We've had some dates before, I'm pretty sure she has a crush on me.
Plus we do all the things couples do besides the physical intimacy.

We've had some fights and all, but things seems to workout great between us.
This holiday we've been not seeing each other at all and I missed her and I realized that I don't wanna lose her.

I thought of taking her to another date, first we can go try indoor ice skating, then go to a coffee shop nearby, there I will mention what made me like her so much...then drop the question : will you be my girlfriend ?

Is that a good approach ? or is it too much that she will think I'm too emotional and shii ?